Basic AL4 support in CI#7972
Merged
Merged
Conversation
maxtropets
force-pushed
the
f/al4-wip
branch
11 times, most recently
from
b606ef9 to
e990329
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces minimal Azure Linux 4 (AL4) coverage in CI (nightly on main and on-demand via the azure-linux-4 label) and makes a handful of small compatibility adjustments across C++, tests, and build tooling to get the codebase building and exercising unit/e2e tests on AL4.
Changes:
- Add a new AL4 GitHub Actions workflow plus an AL4-specific dependency installation script.
- Update a few code paths for AL4 toolchain/library differences (Arrow Parquet reader API, OpenSSL header deprecations, QUIC session member cleanup).
- Minor test harness robustness tweaks (curl
-margument formatting, tolerate additional transient connection errors).
Custom instructions used:
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci-al4.yml |
Adds AL4 CI workflow with VMSS jobs to build and run unit/e2e buckets, with artifact upload of logs. |
scripts/setup-ci-al4.sh |
New AL4 bootstrap script installing build/test deps, Node, h2spec, and Python tooling (uv). |
tests/perf-system/submitter/submit.cpp |
Adds Arrow version gating for Parquet reader creation (Arrow ≥ 19 API change). |
tests/infra/clients.py |
Fixes curl timeout argument formatting by passing -m and its value as separate argv entries. |
tests/connections.py |
Expands transient exception handling to include BrokenPipeError during polling. |
src/quic/quic_session.h |
Removes redundant/shadowing session_id member in derived QUIC session type. |
src/enclave/enclave.h |
Drops OpenSSL engine.h include to align with OpenSSL 3 deprecations. |
include/ccf/crypto/openssl/openssl_wrappers.h |
Drops OpenSSL engine.h include from wrapper header. |
src/crypto/openssl/ec_public_key.cpp |
Drops OpenSSL engine.h include. |
src/crypto/openssl/ec_key_pair.cpp |
Drops OpenSSL engine.h include. |
src/ds/test/openapi.cpp |
Adds std::hash<Baz> specialization to enable schema generation for std::unordered_set<Baz>. |
src/crypto/openssl/hash.cpp |
Adjusts HKDF salt pointer handling for empty salts (review comment raised on semantics risk). |
samples/apps/logging/logging.cpp |
Simplifies unauthenticated caller detection by removing an unused dynamic_cast result variable. |
achamayou
reviewed
Jul 3, 2026
achamayou
reviewed
Jul 3, 2026
achamayou
reviewed
Jul 3, 2026
achamayou
reviewed
Jul 3, 2026
achamayou
reviewed
Jul 3, 2026
achamayou
reviewed
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal AL4 support
azure-linux-4label